Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GDateTime component #16622

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

itisAliRH
Copy link
Member

@itisAliRH itisAliRH commented Aug 31, 2023

This PR adds a new reusable component called GDateTime that provides a date and time picker in a single input group. The component takes/returns a Date object and modifies its time and date whenever the user selects a new date or time.

There is no single component in the current components framework (Bootstrap-Vue) that can handle date and time using a single value at the same time.

image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

itisAliRH and others added 3 commits August 31, 2023 12:36
Co-authored-by: Laila Los <44241786+electronicblueberry@users.noreply.github.com>
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine and simple enough!
Maybe just make the date validation a bit more strict and add a couple of tests for that.

client/src/components/GDateTime.vue Show resolved Hide resolved
client/src/components/GDateTime.vue Show resolved Hide resolved
@davelopez davelopez merged commit af8edd2 into galaxyproject:dev Sep 12, 2023
21 checks passed
@itisAliRH itisAliRH deleted the create-gdatetime-component branch September 14, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants